mirror of
https://github.com/cloudnative-pg/plugin-barman-cloud.git
synced 2026-09-04 22:22:21 +02:00
9fd7ba5b5e
The current configuration derives the sidecar image from configuration paramter `sidecar-image`: 1e13020fe5/internal/cnpgi/operator/lifecycle.go (L418)
However, this is challenging for multi-tenant Kubernetes clusters, as the plugin deployment defines the target sidecar image for all CNPG clusters within a given Kubernetes cluster.
In this PR, we add an optional `sidecarImage` field to `ObjectStore.spec.instanceSidecarConfiguration`.
This allows workloads using a specific ObjectStore to override the Barman Cloud sidecar image configured globally on the plugin deployment.
Signed-off-by: Chandon Pierre <cpierre@coreweave.com>
76 lines
2.4 KiB
Go
76 lines
2.4 KiB
Go
/*
|
|
Copyright © contributors to CloudNativePG, established as
|
|
CloudNativePG a Series of LF Projects, LLC.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
|
|
SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
package operator
|
|
|
|
import (
|
|
"context"
|
|
|
|
barmancloudv1 "github.com/cloudnative-pg/plugin-barman-cloud/api/v1"
|
|
"github.com/cloudnative-pg/plugin-barman-cloud/internal/cnpgi/operator/config"
|
|
)
|
|
|
|
func (impl LifecycleImplementation) collectSidecarImageForRecoveryJob(
|
|
ctx context.Context,
|
|
configuration *config.PluginConfiguration,
|
|
) (string, error) {
|
|
if len(configuration.RecoveryBarmanObjectName) == 0 {
|
|
return "", nil
|
|
}
|
|
|
|
var objectStore barmancloudv1.ObjectStore
|
|
if err := impl.Client.Get(ctx, configuration.GetRecoveryBarmanObjectKey(), &objectStore); err != nil {
|
|
return "", err
|
|
}
|
|
|
|
return objectStore.Spec.InstanceSidecarConfiguration.SidecarImage, nil
|
|
}
|
|
|
|
func (impl LifecycleImplementation) collectSidecarImageForPod(
|
|
ctx context.Context,
|
|
configuration *config.PluginConfiguration,
|
|
) (string, error) {
|
|
// Keep the same precedence used for sidecar resources and arguments.
|
|
switch {
|
|
case len(configuration.BarmanObjectName) > 0:
|
|
var objectStore barmancloudv1.ObjectStore
|
|
if err := impl.Client.Get(ctx, configuration.GetBarmanObjectKey(), &objectStore); err != nil {
|
|
return "", err
|
|
}
|
|
return objectStore.Spec.InstanceSidecarConfiguration.SidecarImage, nil
|
|
|
|
case len(configuration.RecoveryBarmanObjectName) > 0:
|
|
var objectStore barmancloudv1.ObjectStore
|
|
if err := impl.Client.Get(ctx, configuration.GetRecoveryBarmanObjectKey(), &objectStore); err != nil {
|
|
return "", err
|
|
}
|
|
return objectStore.Spec.InstanceSidecarConfiguration.SidecarImage, nil
|
|
|
|
case len(configuration.ReplicaSourceBarmanObjectName) > 0:
|
|
var objectStore barmancloudv1.ObjectStore
|
|
if err := impl.Client.Get(ctx, configuration.GetReplicaSourceBarmanObjectKey(), &objectStore); err != nil {
|
|
return "", err
|
|
}
|
|
return objectStore.Spec.InstanceSidecarConfiguration.SidecarImage, nil
|
|
|
|
default:
|
|
return "", nil
|
|
}
|
|
}
|