plugin-barman-cloud/test/e2e/e2e_suite_test.go
Marco Nenciarini 45c0046946
fix(e2e): use correct image name in kustomize overlay
The e2e kustomize overlay tried to match
docker.io/library/plugin-barman-cloud but the base kustomization at
kubernetes/kustomization.yaml already transforms the bare
plugin-barman-cloud image to the GHCR name. The overlay must match
the base's output (ghcr.io/cloudnative-pg/plugin-barman-cloud-testing)
to override it.

Add comments on both sides to prevent future drift.

Broken since b7daaac (#89) changed the base kustomization's newName
from docker.io/library/plugin-barman-cloud to the GHCR image without
updating the e2e overlay.

Closes #840

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
2026-04-10 18:48:12 +02:00

138 lines
4.3 KiB
Go

/*
Copyright © contributors to CloudNativePG, established as
CloudNativePG a Series of LF Projects, LLC.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
SPDX-License-Identifier: Apache-2.0
*/
package e2e
import (
"context"
"fmt"
"testing"
"time"
"github.com/cloudnative-pg/machinery/pkg/log"
apimachineryTypes "k8s.io/apimachinery/pkg/types"
"k8s.io/apimachinery/pkg/util/wait"
kustomizeTypes "sigs.k8s.io/kustomize/api/types"
"sigs.k8s.io/kustomize/kyaml/resid"
internalClient "github.com/cloudnative-pg/plugin-barman-cloud/test/e2e/internal/client"
"github.com/cloudnative-pg/plugin-barman-cloud/test/e2e/internal/deployment"
"github.com/cloudnative-pg/plugin-barman-cloud/test/e2e/internal/e2etestenv"
"github.com/cloudnative-pg/plugin-barman-cloud/test/e2e/internal/kustomize"
_ "github.com/cloudnative-pg/plugin-barman-cloud/test/e2e/internal/tests/backup"
_ "github.com/cloudnative-pg/plugin-barman-cloud/test/e2e/internal/tests/replicacluster"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
)
// We don't want multiple ginkgo nodes to run the setup concurrently, we use a single cluster for all tests.
var _ = SynchronizedBeforeSuite(func(ctx SpecContext) []byte {
cl, _, err := internalClient.NewClient()
if err != nil {
Fail(fmt.Sprintf("failed to create Kubernetes client: %v", err))
}
if err = e2etestenv.Setup(ctx, cl); err != nil {
Fail(fmt.Sprintf("failed to setup environment: %v", err))
}
const barmanCloudKustomizationPath = "./kustomize/kubernetes/"
barmanCloudKustomization := &kustomizeTypes.Kustomization{
Resources: []string{barmanCloudKustomizationPath},
// Override the image from the base kustomization (kubernetes/kustomization.yaml)
// with the locally-built one. The Name must match the newName in the base.
Images: []kustomizeTypes.Image{
{
Name: "ghcr.io/cloudnative-pg/plugin-barman-cloud-testing",
NewName: "registry.barman-cloud-plugin:5000/plugin-barman-cloud",
NewTag: "testing",
},
},
SecretGenerator: []kustomizeTypes.SecretArgs{
{
GeneratorArgs: kustomizeTypes.GeneratorArgs{
Name: "plugin-barman-cloud",
Behavior: "replace",
KvPairSources: kustomizeTypes.KvPairSources{
LiteralSources: []string{"SIDECAR_IMAGE=registry.barman-cloud-plugin:5000/sidecar-barman-cloud:testing"},
},
},
},
},
Patches: []kustomizeTypes.Patch{
{
Patch: `[{"op": "replace", "path": "/spec/template/spec/containers/0/imagePullPolicy", "value": "Always"}]`,
Target: &kustomizeTypes.Selector{
ResId: resid.ResId{
Gvk: resid.Gvk{
Group: "apps",
Version: "v1",
Kind: "Deployment",
},
Name: "barman-cloud",
Namespace: "cnpg-system",
},
},
Options: nil,
},
},
}
if err := kustomize.ApplyKustomization(ctx, cl, barmanCloudKustomization); err != nil {
Fail(fmt.Sprintf("failed to apply kustomization: %v", err))
}
const defaultTimeout = 1 * time.Minute
ctxDeploy, cancel := context.WithTimeout(ctx, defaultTimeout)
defer cancel()
deploy := apimachineryTypes.NamespacedName{
Namespace: "cnpg-system",
Name: "barman-cloud",
}
err = wait.PollUntilContextCancel(ctxDeploy, 5*time.Second, false,
func(ctx context.Context) (bool, error) {
ready, err := deployment.IsReady(ctx, cl, deploy)
if err != nil {
return false, fmt.Errorf("failed to check if %s is ready: %w", deploy, err)
}
if ready {
return true, nil
}
return false, nil
})
if err != nil {
Fail(fmt.Sprintf("failed to wait for deployment to be ready: %v", err))
}
return []byte{}
}, func(_ []byte) {
logFlags := &log.Flags{}
logFlags.ConfigureLogging()
})
// Run e2e tests using the Ginkgo runner.
func TestE2E(t *testing.T) {
RegisterFailHandler(Fail)
_, _ = fmt.Fprintf(GinkgoWriter, "Starting plugin-barman-cloud suite\n")
RunSpecs(t, "e2e suite")
}