From 877e80572d24e141cbf2b8d2cd3ed1e8f21f1117 Mon Sep 17 00:00:00 2001 From: Armando Ruocco Date: Mon, 22 Sep 2025 11:21:21 +0200 Subject: [PATCH] feat: migrato to string Signed-off-by: Armando Ruocco --- internal/cmd/instance/main.go | 7 ++++--- internal/cnpgi/instance/manager.go | 10 +--------- web/docs/misc.md | 9 +++++---- 3 files changed, 10 insertions(+), 16 deletions(-) diff --git a/internal/cmd/instance/main.go b/internal/cmd/instance/main.go index bc4060f..10a2a8c 100644 --- a/internal/cmd/instance/main.go +++ b/internal/cmd/instance/main.go @@ -52,9 +52,10 @@ func NewCmd() *cobra.Command { }, } - cmd.Flags().Bool("pprof-server", - false, - "If true it will start a pprof debug http server on localhost:6061. Defaults to false.", + cmd.Flags().String("pprof-server", + "", + "The address where pprof server should be exposed, for example: 0.0.0.0:6061. "+ + "Empty string means disabled. Disabled by default", ) _ = viper.BindPFlag("pprof-server", cmd.Flags().Lookup("pprof-server")) diff --git a/internal/cnpgi/instance/manager.go b/internal/cnpgi/instance/manager.go index d87940a..6f82c4c 100644 --- a/internal/cnpgi/instance/manager.go +++ b/internal/cnpgi/instance/manager.go @@ -52,7 +52,7 @@ func Start(ctx context.Context) error { namespace := viper.GetString("namespace") controllerOptions := ctrl.Options{ - PprofBindAddress: getPprofServerAddress(), + PprofBindAddress: viper.GetString("pprof-server"), Scheme: scheme, Client: client.Options{ // Important: the caching options below are used by @@ -149,11 +149,3 @@ func generateScheme(ctx context.Context) *runtime.Scheme { return result } - -func getPprofServerAddress() string { - if viper.GetBool("pprof-server") { - return "0.0.0.0:6061" - } - - return "" -} diff --git a/web/docs/misc.md b/web/docs/misc.md index acad83c..0f03b28 100644 --- a/web/docs/misc.md +++ b/web/docs/misc.md @@ -77,10 +77,11 @@ For a complete list of supported options, refer to the ## Enable the pprof debug server for the sidecar -You can enable the instance sidecar's pprof debug HTTP server by adding the `--pprof-server` flag to the container's -arguments via `.spec.instanceSidecarConfiguration.additionalContainerArgs` in the `ObjectStore` resource. +You can enable the instance sidecar's pprof debug HTTP server by adding the `--pprof-server=
` flag to the container's +arguments via `.spec.instanceSidecarConfiguration.additionalContainerArgs`. -This starts a pprof server on port 6061 inside the Pod. +Pass a bind address in the form `:` (for example, `0.0.0.0:6061`). +An empty value disables the server (disabled by default). ### Example @@ -92,5 +93,5 @@ metadata: spec: instanceSidecarConfiguration: additionalContainerArgs: - - "--pprof-server" + - "--pprof-server=0.0.0.0:6061" ```